Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deno support #1613

Merged
merged 7 commits into from
Feb 2, 2025
Merged

feat: deno support #1613

merged 7 commits into from
Feb 2, 2025

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Jan 31, 2025

Description

image

Testing

should run the same tests as node and bun.

run ./start.sh DENO to collect deno benchmark.

Checklist

  • Conducted a self-review of the code changes.
  • Updated documentation, if necessary.
  • Added tests to validate the functionality or fix.

@DarkGL DarkGL requested review from DarkGL, hoeck and moltar January 31, 2025 20:56
@DarkGL
Copy link
Collaborator

DarkGL commented Jan 31, 2025

First of all great work!

I will try to review it over the weekend :)

@DarkGL
Copy link
Collaborator

DarkGL commented Jan 31, 2025

Some linting error could you check it?

@moltar
Copy link
Owner

moltar commented Jan 31, 2025

I will not have time to review it thoroughly, but it looks good on the surface. I'll trust @DarkGL to make the call.

@scarf005 scarf005 force-pushed the feat/1267/deno-support branch from 483eec9 to da19beb Compare January 31, 2025 22:58
@scarf005
Copy link
Contributor Author

Some linting error could you check it?

there were some comparability issues with deno's npm install equivalent (deno install), i've changed them back to npm ci and it seems to work locally.

@scarf005
Copy link
Contributor Author

scarf005 commented Feb 1, 2025

image

also could workflow approval requirement for first time contributor be lifted?

Copy link
Collaborator

@hoeck hoeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far to me. Thanks for your contribution.

I'll test it later locally to check that that all numbers shown are correct and to get a little feel for deno too. But first I need to update arch and install deno.

deno.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@scarf005 scarf005 force-pushed the feat/1267/deno-support branch from da19beb to 9f6ad22 Compare February 2, 2025 09:51
@DarkGL DarkGL merged commit 3dcc2d4 into moltar:master Feb 2, 2025
9 checks passed
@scarf005 scarf005 deleted the feat/1267/deno-support branch February 2, 2025 11:07
@scarf005 scarf005 mentioned this pull request Feb 2, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] add Deno runtime in benchmark
4 participants