fix: Moves snapshot request synchronously (#2105)

modernuo · Feb 2, 2025 · e64a632 · e64a632
1 parent 717a1a0
commit e64a632
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Projects/Server/Main.cs b/Projects/Server/Main.cs
@@ -517,11 +517,10 @@ public static void RunEventLoop()
         DoKill(_restartOnKill);
     }
 
-    // This is generally called from background threads during Preserialize
     internal static void RequestSnapshot(string snapshotPath)
     {
         _snapshotPath = snapshotPath;
-        _performSnapshot = true; // Set this after the path so race conditions do not occur
+        _performSnapshot = true;
     }
 
     public static void VerifySerialization()

diff --git a/Projects/Server/World/World.cs b/Projects/Server/World/World.cs
@@ -279,8 +279,6 @@ public static void Save()
 
     private static void Preserialize(object state)
     {
-        var tempPath = PathUtility.EnsureRandomPath(_tempSavePath);
-
         try
         {
             // Allocate the heaps for the GC
@@ -290,7 +288,9 @@ private static void Preserialize(object state)
             }
 
             WakeSerializationThreads();
-            Core.RequestSnapshot(tempPath);
+
+            // Execute this synchronously so we don't have a race condition
+            Core.LoopContext.Post(() => Core.RequestSnapshot(PathUtility.EnsureRandomPath(_tempSavePath)));
         }
         catch (Exception ex)
         {