Updates to incorporate/extend AWS RDS instance support #23
Conversation
for aws_rds input, psql client install, and cinc-auditor
add aws_rds support
Signed-off-by: ssayed118 <[email protected]>
| it { should be_listening } | ||
| its('processes') { should match ['postmaster'] } | ||
| end | ||
| if !input('aws_rds') |
There was a problem hiding this comment.
Making conditions based on the aws_rds input may be a good use of the only_if syntax like we are putting more of in RHEL8.
For example:
only_if('Control not applicable - SSH is not installed within containerized RHEL', impact: 0.0) {
!virtualization.system.eql?('docker') || file('/etc/ssh/sshd_config').exist?
}
or in this context something like below (the syntax may not be perfect, but the idea is there):
only_if('Control not applicable - in AWS RDS', impact: 0.0) {
!input(aws_rds)
}
There was a problem hiding this comment.
@em-c-rod Is the 'Control not applicable - SSH is not installed within containerized RHEL' just a comment in the code, or does it actually show up for the user looking at the test results? If the later, we need to be concise on the language/context of this statement.
There was a problem hiding this comment.
It shows up for the user in test results.
For example, in these RHEL8 results
The results for SV-230226, for example, are read as
Skipped control due to only_if condition: The system does not have GNOME installed; this requirement is Not
Applicable.
There was a problem hiding this comment.
Can we improve the cosmetics?
Signed-off-by: ssayed118 <[email protected]>
add aws_rds input
Had intended to delete this sample and require users to construct one based on the README content.
Signed-off-by: seanlongcc <[email protected]>
to match overlay.rb content
to match overlay.rb content
to match overlay.rb content
to match content from overlay.rb
to match overlay.rb content
to match overlay.rb
No description provided.