Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 投稿フォームの絵文字ピッカーに独立したウィンドウを使用できるように #15291

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 15, 2025

What

image

絵文字ピッカーのスタイルの一つとして「ウィンドウ」を復活

  • 投稿フォームを閉じたり、投稿フォームを含むページから離脱したりしたら絵文字ピッカーウィンドウを自動で閉じるように
  • 絵文字ピッカーウィンドウは一つしか開けない

Why

Fix #15290

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 16.75676% with 154 lines in your changes missing coverage. Please review.

Project coverage is 18.82%. Comparing base (ebd06be) to head (0405088).

Files with missing lines Patch % Lines
...es/frontend/src/components/MkEmojiPickerWindow.vue 0.00% 71 Missing and 1 partial ⚠️
packages/frontend/src/scripts/emoji-picker.ts 12.50% 49 Missing ⚠️
...kages/frontend/src/pages/settings/emoji-picker.vue 0.00% 21 Missing ⚠️
...src/components/MkEmojiPickerWindow.stories.impl.ts 0.00% 6 Missing and 1 partial ⚠️
packages/frontend/src/store.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15291       +/-   ##
============================================
- Coverage    37.65%   18.82%   -18.83%     
============================================
  Files         1607      770      -837     
  Lines       204854   111715    -93139     
  Branches      3717     1238     -2479     
============================================
- Hits         77135    21034    -56101     
+ Misses      127071    90088    -36983     
+ Partials       648      593       -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

👀

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 1, 2025
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

👀

@syuilo
Copy link
Member

syuilo commented Feb 11, 2025

リアクションしようとすると表示されないかも

@kakkokari-gtyih
Copy link
Contributor Author

リアクションしようとすると表示されないかも

あーそこ共通だったか

@kakkokari-gtyih
Copy link
Contributor Author

なおったかも

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

投稿フォームの絵文字ピッカーに独立したウィンドウを使用できるように
2 participants