-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new provider GIS #847
base: master
Are you sure you want to change the base?
Add new provider GIS #847
Conversation
I also took the opportunity to update the contribution documentation in order to describe what must be done to add a new provider. |
@mingrammer any chance to have it integrated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small fixes:
- rename the file gis/routing/osmr.png --- > should be osrm.png
- gis/server/mapserver height is over 256, must be 256 max.
- re-run autogen
@gabriel-tessier I just applied all your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlexGacon can you help me check this website/static/img/resources/gis/server/geonetwork.png seem like this img is not match the size of our project. everything else is fine now 👍
@tvqphuoc01 hello! I just pushed the asked changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again to asking changes.
I left copy paste comments...
- There's files that are too big.
- There's one file CAS in resources that is not related with nothing.
- There's 2 certbot and openLdap that are not related with GIS.
Better to have only the changes for GIS provider in this PR.
You can open new PR for the on premise icons.
Just another comment, the icon mapnik is in the cplusplus section, what about move it to 'toolkit' that is more generic name. I found the name 'toolkit' when I searched mapnik on wikipedia! |
Hi I will take care of it tomorrow!
Le mer. 15 janv. 2025, 12:29, gabriel-tessier ***@***.***> a
écrit :
… @AlexGacon <https://github.com/AlexGacon> @tvqphuoc01
<https://github.com/tvqphuoc01>
Just another comment, the icon mapnik is in the cplusplus section, what
about move it to 'toolkit' that is more generic name.
As cplusplus is a language and if they rewrite it in Rust it will no more
be correct.
I found the name 'toolkit' when I searched mapnik on wikipedia!
—
Reply to this email directly, view it on GitHub
<#847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXE4XMSHFGAJHPA5OH5R432KZBC5AVCNFSM6AAAAABVCOVG5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJSGQ2TENRTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@gabriel-tessier regarding mapnik, I have a folder "CLI" which can be seen as toolkit too. Should I rename it "toolkit" or move mapnik into "cli"? |
@gabriel-tessier I just pushed the asked changes. It was in progress work I didn't track correctly. Sorry for the work. |
Let's put it 'cli' with other nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexGacon
All good.
If you have time to move mapnik in 'cli' it's ok if you don't time it's will be also ok, it's not blocking.
I may ask you later an icon for GIS something like a global icon for the provider. It's related to this PR:
#1039
As you pushed a new documentation to add a provider I will update it with instruction to add a top icon for the provider.
I ask again but if it's ok for you I will assign you the issue, I will prepare it before the end of the month.
Thanks again for your contribution.
@gabriel-tessier changes done |
@gabriel-tessier should I change something to pass the pre-commit check? |
I am starting this new provider to gather all GIS (Geographical Information System) related nodes.