Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new provider snowflake #991 #1040

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tiaz0128
Copy link

@tiaz0128 tiaz0128 commented Nov 4, 2024

@filipeaaoliveira

Hello. I'm attempting to resolve this issue. #991

I'm testing to add a new provider 'snowflake'.
I've created a folder resources/snowflake/ and added PNG files that are under 256px in size.

resources/
  └── snowflake/
          ├── bugworkload
          └── workload

Since this is a new provider, I added 'snowflake' to the providers list in the autogen.sh file.
Following the Development Guide, I ran the script autogen.sh.

However, while the image files were successfully copied to website/static/img/resources/snowflake
it seems that the class files are not being generated in diagrams/snowflake.

Would you please help me understand what might be wrong?

@tiaz0128 tiaz0128 changed the title feat: Add new provider snowflake feat: Add new provider snowflake #991 Nov 4, 2024
@filipeaaoliveira
Copy link
Collaborator

Hi @tiaz0128
I did not forget about this, I haven't had the time to look into it, but I'll try to do it this will and will get back to you.
Sorry for the delay.

@tiaz0128
Copy link
Author

tiaz0128 commented Nov 5, 2024

@filipeaaoliveira

Please don't feel pressured. I'm happy to wait until you have time to look into this. Take all the time you need.

@tiaz0128
Copy link
Author

tiaz0128 commented Nov 13, 2024

@filipeaaoliveira @mingrammer

Adding New Provider

I believe I've successfully added a new provider.
There are still a few modifications that might be needed:

  1. Adjusting resource icon sizes
  2. Adding resource icons
  3. Verifying if generated files follow naming conventions

I plan to work on these improvements.
I also want to document the process of adding new providers.
Eventually, I'd like to enhance the scripts to automate provider integration, though this isn't an immediate priority.

Creating diagrams Folder

I noticed that when adding a provider, a new provider folder isn't automatically created under the diagrams directory, so I added this functionality.

The init file also isn't being generated, so I created it manually for now. If this needs to be done manually anyway, I think we should remove this functionality.

os.makedirs(os.path.dirname(mod_path), exist_ok=True)

Bug Fix?

I also discovered and fixed what appears to be a minor bug in the config.py file:

"pve": ("pve"),
"ibm": ("ibm"),

@gabriel-tessier gabriel-tessier force-pushed the 991-feature-request-add-snowflake-icons branch from b7f78ca to a1b4eef Compare January 13, 2025 11:53
@gabriel-tessier gabriel-tessier self-assigned this Jan 13, 2025
@gabriel-tessier
Copy link
Collaborator

Hi @tiaz0128,

Thank you for the PR,

Check the files changed in the following PR and apply them to yours:
#974

Can you revert the changes that are not related to the provider changes, it will make it more easy for us to review. If you find bugs open another PR or issue.

Thanks.

@tiaz0128
Copy link
Author

@gabriel-tessier

I understand! Thank you for your comments! I will make the changes and try again.

@gabriel-tessier
Copy link
Collaborator

There's already a PR with instructions on how to add a provider, it should be more easy check thee changes in the following commit for the contributing file:

https://github.com/mingrammer/diagrams/pull/847/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment, just set the request changes status to prevent merging by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feat/provider Provider request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants