-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new provider snowflake #991 #1040
base: master
Are you sure you want to change the base?
feat: Add new provider snowflake #991 #1040
Conversation
Hi @tiaz0128 |
Please don't feel pressured. I'm happy to wait until you have time to look into this. Take all the time you need. |
b7f78ca
to
a1b4eef
Compare
I understand! Thank you for your comments! I will make the changes and try again. |
There's already a PR with instructions on how to add a provider, it should be more easy check thee changes in the following commit for the contributing file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comment, just set the request changes status to prevent merging by mistake.
@filipeaaoliveira
Hello. I'm attempting to resolve this issue. #991
I'm testing to add a new provider 'snowflake'.
I've created a folder
resources/snowflake/
and added PNG files that are under 256px in size.Since this is a new provider, I added 'snowflake' to the providers list in the
autogen.sh
file.Following the Development Guide, I ran the script autogen.sh.
However, while the image files were successfully copied to
website/static/img/resources/snowflake
it seems that the class files are not being generated in
diagrams/snowflake
.Would you please help me understand what might be wrong?