This repository has been archived by the owner on May 13, 2024. It is now read-only.
Remove support for GL_POINT_SMOOTH and GL_LINE_SMOOTH antialiasing #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These antialiasing techniques have been removed in OpenGL 3.1, they were often executed by the CPU, and Minetest does not use them. The OpenGL wiki recommends that we do not use this functionality in our program. https://www.khronos.org/opengl/wiki/Multisampling#Smooth_antialiasing
sfan5
reviewed
Feb 17, 2024
|
Tested. Works. Including FSAA. (Linux) |
sfan5
reviewed
Feb 17, 2024
| if (FeatureAvailable[IRR_ARB_multisample]) | ||
| if (resetAllRenderStates | ||
| || lastmaterial.AntiAliasing != material.AntiAliasing | ||
| && FeatureAvailable[IRR_ARB_multisample]) { |
There was a problem hiding this comment.
on second look this is actually broken
needs to be (A || B) && C
edit: force-pushed a fix
There was a problem hiding this comment.
You're right, I made a typing error here. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These antialiasing techniques have been removed in OpenGL 3.1, they were often executed by the CPU, and Minetest does not use them. The OpenGL wiki recommends that we do not use this functionality in our program. https://www.khronos.org/opengl/wiki/Multisampling#Smooth_antialiasing