Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Android CI #197

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Android CI #197

merged 5 commits into from
Jan 21, 2024

Conversation

numberZero
Copy link
Contributor

Add Android CI. Mostly a copy from minetest_android_deps where Irrlicht was added before forking.

An alternative would be to use build.sh directly from that repo. But keeping the build script separate from own code makes little sense IMO. A better approach could be to only import _setup_toolchain to ensure compatibility but that requires some changes in the deps repo.

@numberZero numberZero marked this pull request as draft April 23, 2023 13:15
@numberZero
Copy link
Contributor Author

numberZero commented Apr 23, 2023

Note: the CI passes on its own commit, a832635: https://github.com/numberZero/irrlicht/actions/runs/4778460794/jobs/8494894748. The failure is due to later changes in this repo (the “pull request” checks run on the merge result).

@numberZero numberZero marked this pull request as ready for review June 15, 2023 11:49
@numberZero
Copy link
Contributor Author

Now that Android fixes are in master, this simply works. Didn’t test whether the Irrlicht the CI builds works too, though.

@sfan5
Copy link
Member

sfan5 commented Sep 13, 2023

Maybe we can just clone https://github.com/minetest/minetest_android_deps and run the build from there? I'm not too happy about so much duplication.

@numberZero
Copy link
Contributor Author

Maybe we can just clone https://github.com/minetest/minetest_android_deps and run the build from there? I'm not too happy about so much duplication.

JPEG and PNG don’t need to be built here at all anymore as they’re available in the deps since luanti-org/luanti_android_deps#4. But for Irrlicht itself, it’d be rather awkward to keep the build script in a separate repository. For the environment setup it’s possible but copy it or import it, it will be fragile either way.

@sfan5
Copy link
Member

sfan5 commented Jan 21, 2024

I decided my opinion is wrong.

@sfan5 sfan5 merged commit 5b81694 into minetest:master Jan 21, 2024
19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants