Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary native windows support, part 2: standard library and libgerbil #1291

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rujialiu
Copy link
Contributor

@rujialiu rujialiu commented Jan 8, 2025

Much more changes this time :)

Copy link

netlify bot commented Jan 8, 2025

👷 Deploy request for elastic-ritchie-8f47f9 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 26892fa

@vyzo vyzo requested a review from fare January 8, 2025 11:15
@vyzo
Copy link
Collaborator

vyzo commented Jan 8, 2025

@fare first pass again?

@rujialiu
Copy link
Contributor Author

rujialiu commented Jan 9, 2025

General notes

  1. We need win32ports's sys_time_h (https://github.com/win32ports/sys_time_h) and unistd_h (https://github.com/win32ports/unistd_h). That means I need to specify an external include path (in theory msvc can have "default include path" but most of the time we want to avoid it). Currently many codes are compiled even without using the default cc options form environment, so I had to add non-posix-extra-gsc-options to a few places. I didn't use cond-expand because I believe "respect default cc-options from environment variables" is also a correct dehavior for posix systems.
  2. There are quite a bit of code duplications but I decided to keep them because it'll make making platform-specific changes easier (and with more confidence)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants