Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Mozilla.Firefox version 122.0 #136015

Merged
merged 2 commits into from
Jan 26, 2024
Merged

New version: Mozilla.Firefox version 122.0 #136015

merged 2 commits into from
Jan 26, 2024

Conversation

krystofkrticka
Copy link
Contributor

@krystofkrticka krystofkrticka commented Jan 24, 2024 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>? image
  • Does your manifest conform to the 1.5 schema?

Resolves: #135907

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Exorcism0666
Copy link
Contributor

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. Retry-1 flag to indicate retried labels Jan 24, 2024
@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 24, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 24, 2024
@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 24, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 25, 2024
@jedieaston
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 25, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 25, 2024
@PckgrBot
Copy link
Contributor

@stephengillie can you please kick this one off again?

@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 26, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 26, 2024
@stephengillie
Copy link
Collaborator

Hi @krystofkrticka,

This PR's version number 122.0 has 2 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 121.0.1, which has 3 parameters.

Is this intentional?

(Automated response - build 661)

@stephengillie
Copy link
Collaborator

stephengillie commented Jan 26, 2024 •
edited
Loading

Edit: Sorry for duplicate - forgot to unfold the installer file, and had to stop my automation and re-run so it would catch any Apps and Features and not add that message too..

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 26, 2024
@krystofkrticka
Copy link
Contributor Author

@stephengillie thank you for your message I'll look into this once I'm at my computer.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 26, 2024
@krystofkrticka
Copy link
Contributor Author

@stephengillie I just kept version number same as previous version number similar as was for previous version which is that version 121.0 had in manifest 121.0 and version 121.0.1 had in manifest 121.0.1 so unless something changed in manifest schema it is intentional.

@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 26, 2024
@stephengillie
Copy link
Collaborator

I'll add it to my list of exceptions for this check.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit bb08408 into microsoft:master Jan 26, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 26, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@krystofkrticka krystofkrticka deleted the Mozilla.Firefox-122.0-3922908058725F branch January 30, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: Mozilla.Firefox 122.0.0
6 participants
@krystofkrticka @wingetbot @Exorcism0666 @stephengillie @jedieaston @PckgrBot