Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dmypy status file setting #347

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

ivirabyan
Copy link
Contributor

Closes #332

As suggested in the issue, adding daemonStatusFile setting, which allow setting custom status file, so that dmypy can be reused outside the extension.

package.json Outdated
Comment on lines 141 to 147
"mypy-type-checker.daemonStatusFile": {
"default": "",
"markdownDescription": "%settings.daemonStatusFile.description%",
"scope": "resource",
"type": "string"
},
Copy link
Member

@karthiknadig karthiknadig Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add "tags": ["experimental"] to mark a setting a experimental in the UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a33124c

karthiknadig
karthiknadig previously approved these changes Feb 20, 2025
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 20, 2025
TylerLeonhardt
TylerLeonhardt previously approved these changes Feb 20, 2025
@ivirabyan
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Close"

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Feb 21, 2025
@karthiknadig karthiknadig self-assigned this Feb 21, 2025
@karthiknadig karthiknadig enabled auto-merge (squash) February 21, 2025 19:47
@ivirabyan
Copy link
Contributor Author

Is anything else needed for this PR to merged?

@karthiknadig karthiknadig enabled auto-merge (squash) February 25, 2025 15:34
auto-merge was automatically disabled February 25, 2025 15:53

Pull request was closed

@karthiknadig karthiknadig reopened this Feb 25, 2025
@karthiknadig karthiknadig enabled auto-merge (squash) February 25, 2025 15:54
@karthiknadig karthiknadig merged commit befef1d into microsoft:main Feb 25, 2025
39 checks passed
@ivirabyan ivirabyan deleted the daemon-status-file branch February 25, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dmypy status file setting
4 participants