Use json view for jres and refresh file explorer on new generated files #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set .jres as an alias for .json and .blocks as an alias for .html so they're formattable / vscode can treat appropriately. (xml is more accurate for .blocks, but then you have to install a custom formatter as there's no default / etc). I suspect this might actually help out in #70 as liveshare should 'learn' how to handle .jres as just json, but this has been hard to test for me as I somehow got my vscode install to identify .jres / .blocks as these types no matter what I do (I've looked through all the settings files I can find and culled the file assocations but it keeps popping up somehow) -- either way this is how python extension does it / little harm in adding it https://github.com/microsoft/vscode-python/blob/main/package.json#L1517-L1520
One more thing this gets us; anyone who downloads a makecode project with a .blocks or .jres should get us recommended when clicking on 'Search marketplace for extension' I think?
Also, refresh file explorer after the asset editor gives new files (e.g. a tilemap.g.ts is added to the project); currently they don't show up till something else triggers a refresh which was a little confusing.