use offline asseteditor.html from mkc cache #187
Merged
+136
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires microsoft/pxt-mkc#135
this is similar to my last PR adding offline support for the simulator, but this time it's for the asseteditor. as part of this change, i also reimplemented our http request code to use fetch instead of XMLHttpRequest; there was some bug with requests for binary files that i wasn't in the mood to debug so i figured rewriting it with the much more sensical fetch api would be easier
build on this might fail until the linked pr is merged/released