Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: merge main to dev after release #393

Merged
merged 5 commits into from
Feb 21, 2025
Merged

build: merge main to dev after release #393

merged 5 commits into from
Feb 21, 2025

Conversation

blackchoey
Copy link
Collaborator

No description provided.

blackchoey and others added 5 commits February 17, 2025 16:45
* docs: update the readme since deprecate vscode azure account

* docs: update the readme according to comments
* feat: update the auth in feat

* fix: update

* fix: update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (3)

src/commands/authorizations/createAuthorizationAccessPolicy.ts:160

  • Ensure that decoded.payload and decoded.payload.unique_name are not undefined or null before accessing them to avoid runtime errors.
label: nonNullValue(decoded.payload!.unique_name!),

src/commands/authorizations/createAuthorizationAccessPolicy.ts:161

  • Ensure that decoded.payload and decoded.payload.oid are not undefined or null before accessing them to avoid runtime errors.
description: decoded.payload!.oid,

src/explorer/AzureAccountTreeItem.ts:193

  • Replacing session.account.id with session.account.label may introduce a bug if label is not a unique identifier. Verify if label is intended to be used as a unique identifier.
userId: session.account.label,
@blackchoey blackchoey merged commit 2e5043b into dev Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants