fix: fix two issues #391
Merged
fix: fix two issues #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenytang-ms
commented
Feb 19, 2025
| @@ -190,7 +190,7 @@ export class AzureAccountTreeItem extends AzExtParentTreeItem { | |||
| subscriptionId: subscription.subscriptionId || "", | |||
| subscriptionPath: `/subscriptions/${subscription.subscriptionId}`, | |||
| tenantId: subscription.tenantId || "", | |||
| userId: session.account.id, | |||
| userId: session.account.label, | |||
There was a problem hiding this comment.
this filed is align with azure account, debugging with azure account, this userId is user's email.
wenytang-ms
commented
Feb 19, 2025
| @@ -154,9 +155,10 @@ async function populateIdentityOptionsAsync( | |||
|
|
|||
| // 1. Self | |||
| const token = await credential.getToken(); | |||
| const decoded = jwt.decode(token.token, { complete: true }) as any; | |||
There was a problem hiding this comment.
this bug is that azure account return token as a deviceTokenCredentials, in vscode session not support for this, so we need to decode the jwt token.
blackchoey
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix two issues:
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2394438
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2394454