Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate azure account and support select subs and tenant #383

Merged
merged 10 commits into from
Feb 14, 2025
Merged

feat: deprecate azure account and support select subs and tenant #383

merged 10 commits into from
Feb 14, 2025

Conversation

wenytang-ms
Copy link
Contributor

@wenytang-ms wenytang-ms commented Feb 13, 2025 •
edited
Loading

@wenytang-ms wenytang-ms marked this pull request as draft February 13, 2025 07:41
@wenytang-ms wenytang-ms marked this pull request as ready for review February 13, 2025 08:50
@wenytang-ms wenytang-ms changed the title feat: deprecate azure account feat: deprecate azure account and support select subs and tenant Feb 13, 2025
adashen
adashen reviewed Feb 14, 2025
View reviewed changes
blackchoey
blackchoey reviewed Feb 14, 2025
View reviewed changes
blackchoey
blackchoey reviewed Feb 14, 2025
View reviewed changes
blackchoey
blackchoey reviewed Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@blackchoey blackchoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also move related test cases here if possible?

@blackchoey blackchoey changed the base branch from main to dev February 14, 2025 08:14
@wenytang-ms wenytang-ms merged commit dc47391 into dev Feb 14, 2025
2 checks passed
@wenytang-ms wenytang-ms deleted the wenyt/account branch February 14, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adashen adashen adashen left review comments

@blackchoey blackchoey blackchoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenytang-ms @adashen @blackchoey