Skip to content

Commit

Permalink
Fix OpenAPI host url and provisioning (#116)
Browse files Browse the repository at this point in the history
  • Loading branch information
RupengLiu authored Sep 8, 2020
1 parent 4024a99 commit 9372213
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Change Log
All notable changes to the "Azure Api Managment VS Code" extension will be documented in this file.


## [0.1.5 - 2020-09-08]

- Fixed OpenAPI host URL
- Fixed provisioning APIM instance error

## [0.1.4 - 2020-07-27]

- Migrate Vscode Extesion to latest APIM Arm SDK
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "vscode-apimanagement",
"displayName": "Azure API Management",
"description": "An Azure API Management extension for Visual Studio Code.",
"version": "0.1.4",
"version": "0.1.5",
"publisher": "ms-azuretools",
"icon": "resources/azure-apim.png",
"aiKey": "AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217",
Expand Down
3 changes: 2 additions & 1 deletion src/commands/createService/ServiceCreateStep.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export class ServiceCreateStep extends AzureWizardExecuteStep<IServiceWizardCont
wizardContext.service = await wizardContext.client.apiManagementService.createOrUpdate(nonNullValueAndProp(wizardContext.resourceGroup, 'name'), nonNullProp(wizardContext, 'serviceName'), <ApiManagementServiceResource>{
location: nonNullValueAndProp(wizardContext.location, 'name'),
sku: <ApiManagementModels.ApiManagementServiceSkuProperties>{
name: nonNullValueAndProp(wizardContext, 'sku')
name: nonNullValueAndProp(wizardContext, 'sku'),
capacity: wizardContext.sku === 'Consumption' ? 0 : 1
},
publisherEmail: nonNullValueAndProp(wizardContext, 'email'),
publisherName: nonNullValueAndProp(wizardContext, 'email')
Expand Down
2 changes: 1 addition & 1 deletion src/openApi/OpenApiParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class OpenApiParser {
if (version === "2.0") {
const oai20 = <IOpenApi20>source;

oai20.host = proxyHostName;
//oai20.host = proxyHostName;

if (basePath) {
oai20.basePath = basePath;
Expand Down

0 comments on commit 9372213

Please sign in to comment.