perf: update the code according to comments

microsoft · Feb 14, 2025 · 5359230 · 5359230
1 parent 6f4a1d2
commit 5359230
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -791,22 +791,22 @@
                     },
                     "azureApiManagement.selectedSubscriptions": {
                         "type": "array",
-                        "description": "Selected Azure subscriptions",
+                        "description": "%azureApiManagement.selectAzureSubscriptions%",
                         "items": {
                             "type": "string"
                         }
                     },
                     "azureApiManagement.selectedTenant": {
                         "type": "object",
-                        "description": "A specific tenant to sign in to",
+                        "description": "%azureApiManagement.selectAzureTenant%",
                         "properties": {
                             "name": {
                                 "type": "string",
-                                "description": "tenant name"
+                                "description": "%azureApiManagement.selectAzureTenant.tenantName%"
                             },
                             "id": {
                                 "type": "string",
-                                "description": "tenant id"
+                                "description": "%azureApiManagement.selectAzureTenant.tenantId%"
                             }
                         }
                     }

diff --git a/package.nls.json b/package.nls.json
@@ -27,6 +27,10 @@
     "azureApiManagement.openExtensionWorkspaceFolder": "Open extension workspace folder",
     "azureApiManagement.initializeExtensionWorkspaceFolder": "Initialize extension workspace folder",
     "azureApiManagement.advancedPolicyAuthoringExperience": "(Experimental Feature) Enables advanced policy authoring experience.",
+    "azureApiManagement.selectAzureSubscriptions": "Selected Azure subscriptions",
+    "azureApiManagement.selectAzureTenant": "Selected Azure Tenant",
+    "azureApiManagement.selectAzureTenant.tenantName": "tenant name",
+    "azureApiManagement.selectAzureTenant.tennatId": "tenant id",
     "azureApiManagement.extractService": "Extract Service",
     "azureApiManagement.extractApi": "Extract API",
     "azureApiManagement.importFunctionApp": "Import from Azure Functions",

diff --git a/src/commands/openUrl.ts b/src/commands/openUrl.ts
@@ -14,5 +14,7 @@ export async function openUrlFromTreeNode(context: IActionContext, node?: AzExtT
             await openUrl(AzureAccountUrl.createAzureStudentUrl);
             break;
         }
+        default:
+            break;
     }
 }
diff --git a/src/debugger/apimDebug.ts b/src/debugger/apimDebug.ts
@@ -381,7 +381,7 @@ export class ApimDebugSession extends LoggingDebugSession {
 	private async getAccountCredentials(): Promise<TokenCredential> {
 		const session = await AzureAuth.getReadySessionProvider();
 		if (GeneralUtils.failed(session)) {
-			throw new Error("ERROR!");
+			throw new Error("Failed to access the Azure Account Session.");
 		}
 		return await AzureAuth.getCredential(session.result);
 	}
-Original file line number
+Diff line change
@@ Expand Up @@
                 await openUrl(AzureAccountUrl.createAzureStudentUrl);
                 break;
             }
+            default:
+                break;
         }
     }