Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tbb] Fix build for non-English systems #43291

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[tbb] Fix build for non-English systems #43291

merged 1 commit into from
Jan 16, 2025

Conversation

moritz-h
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The TBB build currently fails on non-english systems using GCC. Patch is also submitted upstream. Description see upstream PR: uxlfoundation/oneTBB#1606

@moritz-h moritz-h mentioned this pull request Jan 15, 2025
Open
@BillyONeal BillyONeal changed the title [tbb] Fix build [tbb] Fix build for non-English systems Jan 15, 2025
@BillyONeal BillyONeal enabled auto-merge (squash) January 15, 2025 23:11
@BillyONeal BillyONeal merged commit c811ff4 into microsoft:master Jan 16, 2025
17 checks passed
@moritz-h moritz-h deleted the fix-tbb branch January 18, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FrankXie05 FrankXie05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moritz-h @BillyONeal @FrankXie05