Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_pipeline): enable spn support #291

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −15
Open

feat(data_pipeline): enable spn support #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61ccc99
feat(data_pipeline): enable spn support
DariuszPorowski Mar 7, 2025
d9c9c05
chore: changelog
DariuszPorowski Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/unreleased/changed-20250306-194949.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: changed
body: SPN is now supported for Data Pipeline resources/data-sources
time: 2025-03-06T19:49:49.0668654-08:00
custom:
Issue: "291"
4 changes: 2 additions & 2 deletions docs/data-sources/data_pipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ subcategory: ""
description: |-
Get a Fabric Data Pipeline.
Use this data source to fetch a Data Pipeline https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines.
-> This item does not support Service Principal. Please use a User context authentication.
-> This item supports Service Principal authentication.
~> This data-source is in preview. To access it, you must explicitly enable the preview mode in the provider level configuration.
---

Expand All @@ -15,7 +15,7 @@ Get a Fabric Data Pipeline.

Use this data source to fetch a [Data Pipeline](https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines).

-> This item does not support Service Principal. Please use a User context authentication.
-> This item supports Service Principal authentication.

~> This data-source is in **preview**. To access it, you must explicitly enable the `preview` mode in the provider level configuration.

Expand Down
4 changes: 2 additions & 2 deletions docs/data-sources/data_pipelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ subcategory: ""
description: |-
List a Fabric Data Pipelines.
Use this data source to list Data Pipelines https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines.
-> This item does not support Service Principal. Please use a User context authentication.
-> This item supports Service Principal authentication.
~> This data-source is in preview. To access it, you must explicitly enable the preview mode in the provider level configuration.
---

Expand All @@ -15,7 +15,7 @@ List a Fabric Data Pipelines.

Use this data source to list [Data Pipelines](https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines).

-> This item does not support Service Principal. Please use a User context authentication.
-> This item supports Service Principal authentication.

~> This data-source is in **preview**. To access it, you must explicitly enable the `preview` mode in the provider level configuration.

Expand Down
4 changes: 2 additions & 2 deletions docs/resources/data_pipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ subcategory: ""
description: |-
Manage a Fabric Data Pipeline.
Use this resource to manage Data Pipeline https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines.
-> This item does not support Service Principal. Please use a User context authentication.
-> This item supports Service Principal authentication.
~> This resource is in preview. To access it, you must explicitly enable the preview mode in the provider level configuration.
---

Expand All @@ -15,7 +15,7 @@ Manage a Fabric Data Pipeline.

Use this resource to manage [Data Pipeline](https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines).

-> This item does not support Service Principal. Please use a User context authentication.
-> This item supports Service Principal authentication.

~> This resource is in **preview**. To access it, you must explicitly enable the `preview` mode in the provider level configuration.

Expand Down
2 changes: 1 addition & 1 deletion internal/services/datapipeline/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const (
ItemsName = "Data Pipelines"
ItemsTFName = "data_pipelines"
ItemType = fabcore.ItemTypeDataPipeline
ItemDocsSPNSupport = common.DocsSPNNotSupported
ItemDocsSPNSupport = common.DocsSPNSupported
ItemDocsURL = "https://learn.microsoft.com/fabric/data-factory/data-factory-overview#data-pipelines"
ItemDefinitionEmpty = `{"properties":{"activities":[]}}`
ItemDefinitionPathDocsURL = "https://learn.microsoft.com/fabric/data-factory/pipeline-rest-api"
Expand Down
4 changes: 0 additions & 4 deletions internal/services/datapipeline/data_data_pipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ func TestUnit_DataPipelineDataSource(t *testing.T) {
}

func TestAcc_DataPipelineDataSource(t *testing.T) {
if testhelp.ShouldSkipTest(t) {
t.Skip("No SPN support")
}

workspace := testhelp.WellKnown()["WorkspaceDS"].(map[string]any)
workspaceID := workspace["id"].(string)

Expand Down
4 changes: 0 additions & 4 deletions internal/services/datapipeline/resource_data_pipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,6 @@ func TestUnit_DataPipelineResource_CRUD(t *testing.T) {
}

func TestAcc_DataPipelineResource_CRUD(t *testing.T) {
if testhelp.ShouldSkipTest(t) {
t.Skip("No SPN support")
}

workspace := testhelp.WellKnown()["WorkspaceRS"].(map[string]any)
workspaceID := workspace["id"].(string)

Expand Down
Loading