Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing examples for kql_database and ml_model #258

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

DariuszPorowski
Copy link
Member

πŸ“₯ Pull Request

❓ What are you trying to address

  • Add missing examples for fabric_kql_database
  • Add missing examples for fabric_ml_model
  • Misc: standardize pointers for model setters

Copy link

github-actions bot commented Feb 14, 2025

Changelog Preview

v0.1.0-dev - February 20, 2025

πŸ’« Changed

  • #258 Added missing example for fabric_ml_model resource.
  • #258 Added missing example for fabric_kql_database resource/data-source.

@DariuszPorowski DariuszPorowski added this to the 2025-02 milestone Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 64% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/client 78% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 βœ”
Summary 76% (4220 / 5562) 0 βœ”

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.23%. Comparing base (b1a8416) to head (709890c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/client/logging.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   79.22%   79.23%           
=======================================
  Files         156      156           
  Lines       13382    13381    -1     
=======================================
  Hits        10602    10602           
+ Misses       2775     2774    -1     
  Partials        5        5           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski enabled auto-merge (squash) February 20, 2025 21:47
@DariuszPorowski DariuszPorowski merged commit 0688b44 into main Feb 20, 2025
23 checks passed
@DariuszPorowski DariuszPorowski deleted the misc-cleanup branch February 20, 2025 22:04
DariuszPorowski added a commit that referenced this pull request Feb 28, 2025
## v0.1.0-beta.10 - February 28, 2025

### ✨ Added

*
[#256](#256)
Onboard new resource/data-source `fabric_activator` (also known as
reflex).
*
[#197](#197)
Onboard new resource/data-source `fabric_graphql_api`.
*
[#255](#255)
Onboard new resource/data-source `fabric_sql_database`.

### πŸ’« Changed

*
[#258](#258)
Added missing example for `fabric_ml_model` resource.
*
[#258](#258)
Added missing example for `fabric_kql_database` resource/data-source.

### πŸͺ² Fixed

*
[#256](#256)
Missing preview note in list data-sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants