Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint and code cleanup #251

Merged
merged 1 commit into from
Feb 13, 2025
Merged

chore: lint and code cleanup #251

merged 1 commit into from
Feb 13, 2025

Conversation

DariuszPorowski
Copy link
Member

πŸ“₯ Pull Request

❓ What are you trying to address

This pull request includes several changes to the codebase, mainly focusing on linting and code cleanup by replacing the use of context.Background() with t.Context() in test files and modifying the setConfig and mapConfig methods to return the context.

Copy link

github-actions bot commented Feb 13, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 64% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/client 70% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 βœ”
Summary 76% (4220 / 5563) 0 βœ”

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.27451% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.22%. Comparing base (2d2b7c1) to head (d612edc).

Files with missing lines Patch % Lines
internal/provider/provider.go 86.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files         156      156           
  Lines       13381    13382    +1     
=======================================
+ Hits        10601    10602    +1     
  Misses       2775     2775           
  Partials        5        5           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@badeamarjieh badeamarjieh merged commit 108d209 into main Feb 13, 2025
25 of 26 checks passed
@badeamarjieh badeamarjieh deleted the lint-cleanup branch February 13, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants