Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): enable sdk logging only when target level is not set to off #249

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

DariuszPorowski
Copy link
Member

πŸ“₯ Pull Request

❓ What are you trying to address

This pull request includes a change to the internal/provider/client/logging.go file to improve the logging configuration for the Fabric SDK. The most important change is the modification of the logic that enables Azure SDK logging based on the target logging level.

Logging configuration improvement:

  • internal/provider/client/logging.go: Adjusted the logic to enable Azure SDK logging only if the target logging level is not set to "off". This ensures that logging is properly configured based on the specified level.

@DariuszPorowski DariuszPorowski enabled auto-merge (squash) February 12, 2025 16:25
Copy link

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/client 70% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 79% 0 βœ”
Summary 76% (4208 / 5545) 0 βœ”

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 79.24%. Comparing base (5ba6f57) to head (bb19cdc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   79.27%   79.24%   -0.04%     
==========================================
  Files         155      156       +1     
  Lines       13300    13329      +29     
==========================================
+ Hits        10544    10562      +18     
- Misses       2752     2763      +11     
  Partials        4        4              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski merged commit 79068fb into main Feb 12, 2025
25 of 26 checks passed
@DariuszPorowski DariuszPorowski deleted the fix/sdk-log branch February 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants