Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rs-spark_custom_pool): inconsistent result for dynamic_executor_allocation #240

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

fix #239

❓ What are you trying to address

This pull request includes changes to address the inconsistent results for dynamic executor allocation when the enabled attribute is set to false and updates the documentation and schema accordingly.

✨ Description of new changes

Code updates:

  • internal/services/spark/resource_spark_custom_pool.go:
    • Added new imports for attr, types, and superint32validator packages.
    • Updated the schema for min_executors and max_executors attributes to be Computed and Optional, and added validators to handle the dynamic_executor_allocation enabled attribute.

Documentation updates:

Copy link

github-actions bot commented Feb 6, 2025

Changelog Preview

v0.1.0-dev - February 12, 2025

✨ Added

  • #237 Enable API/SDK interaction logging.

🪲 Fixed

  • #239 Inconsistent result for dynamic_executor_allocation (min_executors/max_executors) when enabled is false.

Copy link

github-actions bot commented Feb 7, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/client 70% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 76% (4206 / 5545) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (5ba6f57) to head (e5b5355).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   79.27%   79.25%   -0.03%     
==========================================
  Files         155      156       +1     
  Lines       13300    13351      +51     
==========================================
+ Hits        10544    10581      +37     
- Misses       2752     2766      +14     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski merged commit a0b6ea7 into main Feb 12, 2025
23 checks passed
@DariuszPorowski DariuszPorowski deleted the fix/bug-239 branch February 12, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fabric_spark_custom_pool: Provider produced inconsistent result after apply
3 participants