-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rs-spark_custom_pool): inconsistent result for dynamic_executor_allocation #240
Merged
+96
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
c693a7b
to
801a4ff
Compare
Minimum allowed line rate is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 79.27% 79.25% -0.03%
==========================================
Files 155 156 +1
Lines 13300 13351 +51
==========================================
+ Hits 10544 10581 +37
- Misses 2752 2766 +14
Partials 4 4 ☔ View full report in Codecov by Sentry. |
801a4ff
to
b9f5db2
Compare
b9f5db2
to
a6d879a
Compare
a6d879a
to
e5b5355
Compare
PabloZaiden
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
fix #239
❓ What are you trying to address
This pull request includes changes to address the inconsistent results for dynamic executor allocation when the
enabled
attribute is set to false and updates the documentation and schema accordingly.✨ Description of new changes
Code updates:
internal/services/spark/resource_spark_custom_pool.go
:attr
,types
, andsuperint32validator
packages.min_executors
andmax_executors
attributes to beComputed
andOptional
, and added validators to handle thedynamic_executor_allocation
enabled
attribute.Documentation updates:
docs/resources/spark_custom_pool.md
: Added anOptional
section to the documentation formax_executors
andmin_executors
attributes.