Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): prepare payload based on file type - text vs non-text based #238

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

fix #235

❓ What are you trying to address

This pull request includes several changes across multiple files to fix an error with referencing non-text sources for Fabric Item Definition parts include testing of non-text definition part (png file).

Copy link

github-actions bot commented Feb 6, 2025

Changelog Preview

v0.1.0-dev - February 12, 2025

✨ Added

  • #237 Enable API/SDK interaction logging.

🪲 Fixed

  • #235 Error when referencing non-text source for Fabric Item Definition part.
  • #239 Inconsistent result for dynamic_executor_allocation (min_executors/max_executors) when enabled is false.

Copy link

github-actions bot commented Feb 6, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 64% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/client 70% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 76% (4219 / 5562) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 36 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (5ba6f57) to head (a11295f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/transforms/payload.go 46.77% 33 Missing ⚠️
.../pkg/fabricitem/models_resource_item_definition.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   79.27%   79.20%   -0.08%     
==========================================
  Files         155      156       +1     
  Lines       13300    13384      +84     
==========================================
+ Hits        10544    10601      +57     
- Misses       2752     2779      +27     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski merged commit 7d47ea2 into main Feb 12, 2025
23 checks passed
@DariuszPorowski DariuszPorowski deleted the fix/bug-235 branch February 12, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fabric_report bad character when referencing png resource under RegisteredResources
3 participants