Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rs-eventhouse): add configuration support #224

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

DariuszPorowski
Copy link
Member

πŸ“₯ Pull Request

❓ What are you trying to address

This pull request introduces several changes to the fabric_eventhouse resource, including the addition of a new configuration attribute and updates to the documentation and tests.

Copy link

github-actions bot commented Jan 28, 2025

Changelog Preview

v0.1.0-dev - January 30, 2025

πŸ’₯ Breaking

  • #171 The format attribute is now REQUIRED for Resources/Data-Sources with definition support.
    Currently applicable to the following Resources/Data-Sources: Report, Notebook, Semantic Model, and Spark Job Definition.

  • #185 Using preview resources or data sources now needs explicit opt-in at the provider level configuration by setting the preview attribute to true.
    This is to ensure that users are aware of the risks of using preview resources or data sources in production environments.
    Usage of any preview feature will result in a warning message in the Terraform output.

✨ Added

  • #168 Added support for multi-format Notebook Resource/Data-Source.
    By using format attribute, you can now define the format of the Notebook Resource/Data-Source. Accepted values are jpynb, and py.

  • #171 Added support for multi-format Report Resource/Data-Source.
    By using format attribute, you can now define the format of the Report Resource/Data-Source. Accepted values are PBIR, and PBIR-Legacy.

  • #171 Added support for multi-format Semantic Model Resource/Data-Source.
    By using format attribute, you can now define the format of the Semantic Model Resource/Data-Source. Accepted values are TMSL, and TMDL.

  • #135 Definition support in the fabric_eventhouse Resource

  • #156 Definition support in the fabric_eventhouse Data-Sources

  • #201 Added additional properties for fabric_spark_workspace_settings Data-Source and Resource:

  • high_concurrency.notebook_pipeline_run_enabled (Boolean)
  • job.conservative_job_admission_enabled (Boolen)
  • job.session_timeout_in_minutes (Number)
  • #224 New configuration attribute in the fabric_eventhouse Resource.

πŸ’« Changed

  • #194 Enabled SPN support for Warehouse

πŸͺ² Fixed

  • #174 Provider produced inconsistent result after apply error appears when using fabric_domain_workspace_assignments multiple times due to enforce assignments based only on TF configuration and ignoring the real state on the Fabric side.
    Resource must only manage TF provided configuration and ignore any configuration provided outside TF.

  • #190 Fixed typo in the "Creating an App Registration for the User context" doc

@DariuszPorowski DariuszPorowski added this to the 2025-01 milestone Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 81% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 79% 0 βœ”
Summary 76% (4170 / 5518) 0 βœ”

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (c4ec29d) to head (51a4a5f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...item/resource_item_config_definition_properties.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   76.72%   78.89%   +2.16%     
==========================================
  Files         151      151              
  Lines       13175    13209      +34     
==========================================
+ Hits        10109    10421     +312     
+ Misses       3062     2784     -278     
  Partials        4        4              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski merged commit aef565f into main Jan 30, 2025
22 of 23 checks passed
@DariuszPorowski DariuszPorowski deleted the feat/eventhouse_config branch January 30, 2025 16:14
hattan added a commit that referenced this pull request Jan 30, 2025
## v0.1.0-beta.8 - January 30, 2025

### πŸ’₯ Breaking

*
[#171](#171)
The `format` attribute is now REQUIRED for Resources/Data-Sources with
definition support.
Currently applicable to the following Resources/Data-Sources: Report,
Notebook, Semantic Model, and Spark Job Definition.

*
[#185](#185)
Using preview resources or data sources now needs explicit opt-in at the
provider level configuration by setting the `preview` attribute to
`true`.
This is to ensure that users are aware of the risks of using preview
resources or data sources in production environments.
Usage of any preview feature will result in a warning message in the
Terraform output.

### ✨ Added

*
[#168](#168)
Added support for multi-format Notebook Resource/Data-Source.
By using `format` attribute, you can now define the format of the
Notebook Resource/Data-Source. Accepted values are `jpynb`, and `py`.

*
[#171](#171)
Added support for multi-format Report Resource/Data-Source.
By using `format` attribute, you can now define the format of the Report
Resource/Data-Source. Accepted values are `PBIR`, and `PBIR-Legacy`.

*
[#171](#171)
Added support for multi-format Semantic Model Resource/Data-Source.
By using `format` attribute, you can now define the format of the
Semantic Model Resource/Data-Source. Accepted values are `TMSL`, and
`TMDL`.

*
[#135](#135)
Definition support in the `fabric_eventhouse` Resource
*
[#156](#156)
Definition support in the `fabric_eventhouse` Data-Sources
*
[#201](#201)
Added additional properties for `fabric_spark_workspace_settings`
Data-Source and Resource:
* `high_concurrency.notebook_pipeline_run_enabled` (Boolean)
* `job.conservative_job_admission_enabled` (Boolen)
* `job.session_timeout_in_minutes` (Number)

*
[#159](#159)
Definition support in the `fabric_eventstream` Resource
*
[#160](#160)
Definition support in the `fabric_eventstream` Data-Source
*
[#130](#130)
New Resource: `fabric_kql_queryset`
*
[#131](#131)
Definition support in the `fabric_kql_queryset` Data-Source
*
[#134](#134)
New Resource/Data-Source: `fabric_kql_dashboard`
*
[#224](#224)
New `configuration` attribute in the `fabric_eventhouse` Resource.

### πŸ’« Changed

*
[#194](#194)
Enabled SPN support for Warehouse

### πŸͺ² Fixed

*
[#174](#174)
`Provider produced inconsistent result after apply` error appears when
using `fabric_domain_workspace_assignments` multiple times due to
enforce assignments based only on TF configuration and ignoring the real
state on the Fabric side.
Resource must only manage TF provided configuration and ignore any
configuration provided outside TF.

*
[#190](#190)
Fixed typo in the "Creating an App Registration for the User context"
doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants