-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lychee for links checking #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8356f9b
to
1caf0f7
Compare
Minimum allowed line rate is |
PabloZaiden
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great idea to check the links from now on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π₯ Pull Request
β What are you trying to address
This pull request includes several changes aimed at enhancing link checking, updating documentation URLs, and adding new tasks to the
Taskfile.yml
.β¨ Description of new changes
Enhancements to Link Checking:
.github/linters/.lychee.toml
: Added a new configuration file for thelychee
link checker to enable caching, set runtime parameters, customize request headers, and exclude certain IP ranges from checking.Taskfile.yml
: Added a new tasklint:links
to run thelychee
link checker using the new configuration file.Taskfile.yml
: Added a new taskinstall:lychee
to install thelychee
link checker on different platforms (Windows, Linux, macOS).Documentation Updates:
docs/data-sources/sql_endpoints.md
: Updated URLs to point to the correct Microsoft documentation for SQL Endpoints.internal/services/sqlendpoint/base.go
: Updated theItemDocsURL
constant to reflect the new URL for SQL Endpoints documentation.Minor Fixes:
DEVELOPER.md
: Fixed a relative link to theghpages.yml
GitHub workflow.