Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable support for spn for eventstream #148

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Dec 13, 2024

πŸ“₯ Pull Request

❓ What are you trying to address

  • Enabled SPN support for Eventstream
  • bonus: run a few domains related tests using SPN, domains not fully support SPN to onboard for everything

Copy link

github-actions bot commented Dec 13, 2024

Changelog Preview

v0.1.0-dev - December 16, 2024

πŸ’« Changed

  • #126 Enhance error handling by improving the diagnostic message - add additional error details, error codes and request ID.
  • #148 Enabled SPN support for Eventstream

@DariuszPorowski DariuszPorowski changed the title docs: update documentation to indicate support for spn feat: enable support for spn for eventstream Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 78% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 82% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 79% 0 βœ”
Summary 74% (3671 / 4950) 0 βœ”

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 78.21%. Comparing base (94935b7) to head (98ed887).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   77.99%   78.21%   +0.22%     
==========================================
  Files         130      130              
  Lines       12172    12212      +40     
==========================================
+ Hits         9493     9552      +59     
+ Misses       2675     2655      -20     
- Partials        4        5       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski marked this pull request as ready for review December 13, 2024 20:22
@DariuszPorowski DariuszPorowski requested a review from a team as a code owner December 13, 2024 20:22
Copy link
Contributor

@PabloZaiden PabloZaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@DariuszPorowski DariuszPorowski enabled auto-merge (squash) December 16, 2024 19:23
@DariuszPorowski DariuszPorowski merged commit 2d5df61 into main Dec 16, 2024
24 checks passed
@DariuszPorowski DariuszPorowski deleted the feat/spn-support branch December 16, 2024 20:21
DariuszPorowski added a commit that referenced this pull request Dec 20, 2024
## v0.1.0-beta.7 - December 19, 2024

### ✨ Added

*
[#157](#157)
Added extended properties to `fabric_spark_job_definition` Data Source.
*
[#158](#158)
Added extended properties to `fabric_spark_job_definition` Resource.

### πŸ’« Changed

*
[#126](#126)
Enhance error handling by improving the diagnostic message - add
additional error details, error codes and request ID.
*
[#148](#148)
Enabled SPN support for Eventstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants