feat(warehouse): enable spn support (#194)

# 📥 Pull Request Enabled SPN support for Warehouse
microsoft · Jan 15, 2025 · e32c845 · e32c845
1 parent 7562e71
commit e32c845
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 19 deletions.
diff --git a/.changes/unreleased/changed-20250115-003905.yaml b/.changes/unreleased/changed-20250115-003905.yaml
@@ -0,0 +1,5 @@
+kind: changed
+body: Enabled SPN support for Warehouse
+time: 2025-01-15T00:39:05.6386534-08:00
+custom:
+    Issue: "194"
diff --git a/docs/data-sources/warehouse.md b/docs/data-sources/warehouse.md
@@ -5,7 +5,7 @@ subcategory: ""
 description: |-
   Get a Fabric Warehouse.
   Use this data source to fetch a Warehouse https://learn.microsoft.com/fabric/data-warehouse/data-warehousing.
-  -> This item does not support Service Principal. Please use a User context authentication.
+  -> This item supports Service Principal authentication.
   ~> This data-source is in preview. To access it, you must explicitly enable the preview mode in the provider level configuration.
 ---
 
@@ -15,7 +15,7 @@ Get a Fabric Warehouse.
 
 Use this data source to fetch a [Warehouse](https://learn.microsoft.com/fabric/data-warehouse/data-warehousing).
 
--> This item does not support Service Principal. Please use a User context authentication.
+-> This item supports Service Principal authentication.
 
 ~> This data-source is in **preview**. To access it, you must explicitly enable the `preview` mode in the provider level configuration.
 

diff --git a/docs/data-sources/warehouses.md b/docs/data-sources/warehouses.md
@@ -5,7 +5,7 @@ subcategory: ""
 description: |-
   List a Fabric Warehouses.
   Use this data source to list Warehouses https://learn.microsoft.com/fabric/data-warehouse/data-warehousing.
-  -> This item does not support Service Principal. Please use a User context authentication.
+  -> This item supports Service Principal authentication.
 ---
 
 # fabric_warehouses (Data Source)
@@ -14,7 +14,7 @@ List a Fabric Warehouses.
 
 Use this data source to list [Warehouses](https://learn.microsoft.com/fabric/data-warehouse/data-warehousing).
 
--> This item does not support Service Principal. Please use a User context authentication.
+-> This item supports Service Principal authentication.
 
 ## Example Usage
 

diff --git a/docs/resources/warehouse.md b/docs/resources/warehouse.md
@@ -5,7 +5,7 @@ subcategory: ""
 description: |-
   Manage a Fabric Warehouse.
   Use this resource to manage a Warehouse https://learn.microsoft.com/fabric/data-warehouse/data-warehousing.
-  -> This item does not support Service Principal. Please use a User context authentication.
+  -> This item supports Service Principal authentication.
   ~> This resource is in preview. To access it, you must explicitly enable the preview mode in the provider level configuration.
 ---
 
@@ -15,7 +15,7 @@ Manage a Fabric Warehouse.
 
 Use this resource to manage a [Warehouse](https://learn.microsoft.com/fabric/data-warehouse/data-warehousing).
 
--> This item does not support Service Principal. Please use a User context authentication.
+-> This item supports Service Principal authentication.
 
 ~> This resource is in **preview**. To access it, you must explicitly enable the `preview` mode in the provider level configuration.
 

diff --git a/internal/services/warehouse/base.go b/internal/services/warehouse/base.go
@@ -15,7 +15,7 @@ const (
 	ItemsName          = "Warehouses"
 	ItemsTFName        = "warehouses"
 	ItemType           = fabcore.ItemTypeWarehouse
-	ItemDocsSPNSupport = common.DocsSPNNotSupported
+	ItemDocsSPNSupport = common.DocsSPNSupported
 	ItemDocsURL        = "https://learn.microsoft.com/fabric/data-warehouse/data-warehousing"
 	ItemPreview        = true
 )
diff --git a/internal/services/warehouse/data_warehouse_test.go b/internal/services/warehouse/data_warehouse_test.go
@@ -156,10 +156,6 @@ func TestUnit_WarehouseDataSource(t *testing.T) {
 }
 
 func TestAcc_WarehouseDataSource(t *testing.T) {
-	if testhelp.ShouldSkipTest(t) {
-		t.Skip("No SPN support")
-	}
-
 	workspace := testhelp.WellKnown()["WorkspaceDS"].(map[string]any)
 	workspaceID := workspace["id"].(string)
 

diff --git a/internal/services/warehouse/data_warehouses_test.go b/internal/services/warehouse/data_warehouses_test.go
@@ -78,10 +78,6 @@ func TestUnit_WarehousesDataSource(t *testing.T) {
 }
 
 func TestAcc_WarehousesDataSource(t *testing.T) {
-	if testhelp.ShouldSkipTest(t) {
-		t.Skip("No SPN support")
-	}
-
 	workspace := testhelp.WellKnown()["WorkspaceDS"].(map[string]any)
 	workspaceID := workspace["id"].(string)
 

diff --git a/internal/services/warehouse/resource_warehouse_test.go b/internal/services/warehouse/resource_warehouse_test.go
@@ -217,10 +217,6 @@ func TestUnit_WarehouseResource_CRUD(t *testing.T) {
 }
 
 func TestAcc_WarehouseResource_CRUD(t *testing.T) {
-	if testhelp.ShouldSkipTest(t) {
-		t.Skip("No SPN support")
-	}
-
 	workspace := testhelp.WellKnown()["WorkspaceRS"].(map[string]any)
 	workspaceID := workspace["id"].(string)