Fix MSBuild not continuing until Visual Studio closed (#348)

Setting `UseShellExecute` to `true` seems to fix the scenario when SlnGen is run as a task but MSBuild does not continue after the task completes since it monitors child processes. Fixes #342
microsoft · Apr 14, 2022 · b375dad · b375dad
1 parent 53e0ac5
commit b375dad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Packages.props b/Packages.props
@@ -30,6 +30,7 @@
   </ItemGroup>
   <ItemGroup>
     <GlobalPackageReference Include="Microsoft.Build.Artifacts" Version="2.2.0" />
+    <GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" />
     <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
     <GlobalPackageReference Include="Microsoft.VisualStudioEng.MicroBuild.Core" Version="1.0.0" />
     <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.4.255" />

diff --git a/src/Microsoft.VisualStudio.SlnGen/VisualStudioLauncher.cs b/src/Microsoft.VisualStudio.SlnGen/VisualStudioLauncher.cs
@@ -88,7 +88,7 @@ public static bool TryLaunch(ProgramArguments arguments, VisualStudioInstance vi
                     {
                         FileName = devEnvFullPath,
                         Arguments = commandLineBuilder.ToString(),
-                        UseShellExecute = false,
+                        UseShellExecute = true,
                     },
                 };