-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node-core-library] Implement json-schema 'draft-07' validation #4714
Merged
iclanton
merged 20 commits into
microsoft:main
from
bartvandenende-wm:bartvandenende-wm/support-json-schema-draft-07
May 21, 2024
Merged
[node-core-library] Implement json-schema 'draft-07' validation #4714
iclanton
merged 20 commits into
microsoft:main
from
bartvandenende-wm:bartvandenende-wm/support-json-schema-draft-07
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartvandenende-wm
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
May 15, 2024 15:10
bartvandenende-wm
changed the title
[node-core-library] Implements json-schema 'draft-07' validation in JsonFile / JsonSchema
[node-core-library] Implement json-schema 'draft-07' validation
May 15, 2024
iclanton
reviewed
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
I'm going to disable automatic publishing for now. If we're going to do a major bump of node-core-library
, there are some other changes we should make at the same time.
...hstack/heft-config-file/bartvandenende-wm-support-json-schema-draft-07_2024-05-15-16-44.json
Outdated
Show resolved
Hide resolved
.../localization-utilities/bartvandenende-wm-support-json-schema-draft-07_2024-05-15-18-42.json
Outdated
Show resolved
Hide resolved
.../@rushstack/rig-package/bartvandenende-wm-support-json-schema-draft-07_2024-05-15-14-55.json
Outdated
Show resolved
Hide resolved
...changes/@microsoft/rush/bartvandenende-wm-support-json-schema-draft-07_2024-05-15-16-44.json
Outdated
Show resolved
Hide resolved
libraries/heft-config-file/src/test/__snapshots__/ConfigurationFile.test.ts.snap
Outdated
Show resolved
Hide resolved
…port-json-schema-draft-07 # Conflicts: # common/config/subspaces/default/repo-state.json
…port-json-schema-draft-07 # Conflicts: # common/config/subspaces/default/repo-state.json
iclanton
approved these changes
May 21, 2024
auto-merge was automatically disabled
May 21, 2024 03:33
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[node-core-library] Implements json-schema 'draft-07' validation in JsonFile / JsonSchema
Fixes #4713
Details
This PR:
@rushstack/node-core-library
ajv
applies additional validation on the correctness of the schema per https://ajv.js.org/options.html#strictschemastring
type.Notes:
How it was tested
Impacted documentation
N/A