Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Minor cleanup to the build cache code. #4548

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

iclanton
Copy link
Member

@iclanton iclanton commented Feb 27, 2024

Summary

Minor cleanup to the build cache code.

How it was tested

It will be tested by the PR build.

Impacted documentation

None.

…tryNamePattern property in config/rush-project.json.
Copy link
Contributor

@dmichon-msft dmichon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but an explanation of the motivation of the feature would be appreciated.

@iclanton iclanton changed the title [rush] Add the ability to override a project's cache ID via a projectCacheEntryNamePattern property in config/rush-project.json. [rush] Clean up the project caching code. Feb 28, 2024
@iclanton iclanton changed the title [rush] Clean up the project caching code. [rush] Minor cleanup to the build cache code. Feb 28, 2024
@iclanton iclanton enabled auto-merge February 28, 2024 19:43
@iclanton iclanton merged commit f7fd624 into microsoft:main Feb 28, 2024
5 checks passed
@iclanton iclanton deleted the per-project-cache-id branch February 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants