addressing PR comments. 1. Made the params nullable 2. change case of…

… LocalEndPoint var
microsoft · Dec 20, 2023 · ff4bd2b · ff4bd2b
1 parent 9815037
commit ff4bd2b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/TelemetryConsumption/Kestrel/IKestrelTelemetryConsumer.cs b/src/TelemetryConsumption/Kestrel/IKestrelTelemetryConsumer.cs
@@ -17,7 +17,7 @@ public interface IKestrelTelemetryConsumer
     /// <param name="connectionId">ID of the connection.</param>
     /// <param name="localEndPoint">Local endpoint for the connection.</param>
     /// <param name="remoteEndPoint">Remote endpoint for the connection.</param>
-    void OnConnectionStart(DateTime timestamp, string connectionId, string localEndPoint, string remoteEndPoint) { }
+    void OnConnectionStart(DateTime timestamp, string connectionId, string? localEndPoint, string? remoteEndPoint) { }
 
     /// <summary>
     /// Called at the end of a connection.

diff --git a/src/TelemetryConsumption/Kestrel/KestrelEventListenerService.cs b/src/TelemetryConsumption/Kestrel/KestrelEventListenerService.cs
@@ -32,11 +32,11 @@ protected override void OnEvent(IKestrelTelemetryConsumer[] consumers, EventWrit
                 Debug.Assert(eventData.EventName == "ConnectionStart" && payload.Count == 3);
                 {
                     var connectionId = (string)payload[0];
-                    var LocalEndPoint = (string)payload[1];
-                    var remoteEndPoint = (string)payload[2];
+                    var localEndPoint = (string?)payload[1];
+                    var remoteEndPoint = (string?)payload[2];
                     foreach (var consumer in consumers)
                     {
-                        consumer.OnConnectionStart(eventData.TimeStamp, connectionId, LocalEndPoint, remoteEndPoint);
+                        consumer.OnConnectionStart(eventData.TimeStamp, connectionId, localEndPoint, remoteEndPoint);
                     }
                 }
                 break;