Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RCTAppDelegate::bundleURL not implemented #2309

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

DanielSRS
Copy link

Summary:

RNM 0.76 apps created with react-native-macos-init fails to load the javascript bundle at start due to a missing implementation of RCTAppDelegate::bundleURL in the template, as described in #2305

this PR just updates the template to add the missing method

Test Plan:

Run react-native-macos-init and check that the created project builds and run

@tido64
Copy link
Member

tido64 commented Dec 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Saadnajmi
Copy link
Collaborator

Sorry for the delay,I was double checking whether we should just get rid of sourceURLForBridge altogether (I think not, an iOS project generated with @react-native-community/cli init still has it). If you want to have this change in 0.76, feel free make a PR against 0.76-stable

@Saadnajmi Saadnajmi merged commit 0f05bfc into microsoft:0.76-stable Dec 12, 2024
10 checks passed
@Saadnajmi
Copy link
Collaborator

Sorry for the delay,I was double checking whether we should just get rid of sourceURLForBridge altogether (I think not, an iOS project generated with @react-native-community/cli init still has it). If you want to have this change in 0.76, feel free make a PR against 0.76-stable

Oh wait. This was on 0.76-stable. Could you also make a PR against main @DanielSRS ?

@DanielSRS
Copy link
Author

Sorry, I just realized that I should've put 0.76 on the title to make it clear where the fix was landing 😅

I created another PR against main with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants