Convert pxtrunner into modules #9828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let theme = pxt.appTarget.appTheme; | ||
| let body = $('body'); | ||
| let $footer = $(footer) | ||
| let footera = $('<a/>').attr('href', theme.homeUrl) |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
|
Question: How will moving to modules impact shims? I know you said that we're not making everything to modules yet but would like to. If we change everything be a module, would we have to change how we connect logic between C++ and TypeScript? |
srietkerk
reviewed
Jan 23, 2024
|
@srietkerk when i say switching to modules, i only mean for web code. "user code", like the stuff in the libs/ folder, won't be changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks much bigger than it actually is; you probably want to view the diff with ignore whitespace turned on.
Making this change because our new Blockly code is module based so everything that interacts with Blockly needs to be a module as well. There are no real changes to code here, just a straight conversion from namespaces to modules and fixing a bunch of qualified names.
I also defined a new file,
pxtrunner/embed.ts, which puts all of the runner code into the global namespace so it can be appended to pxtembed.js (which is itself included in various pages like --docs, --embed, --run, etc.). The file serves as the entrypoint for browserifyEventually I'll get around to converting everything into modules and that file will no longer be necessary