Theme Keyboard Nav & Melody Editor Fix #10417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed colors (matching the block colors), we can simply hard-code the color for this input as well.
… into the tab ordering)
srietkerk
reviewed
Mar 8, 2025
| key={theme.id} | ||
| onClick={() => onClick(theme)} | ||
| tabIndex={onClick && 0} |
There was a problem hiding this comment.
Should onClick just be necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds keyboard nav support for the theme picker modal (just needed to add the cards into the tab ordering), and it fixes the bpm box in the melody editor (since the whole thing is hard-coded to block colors, we can just hardcode the input color as well).
Fixes microsoft/pxt-arcade#6773
Fixes microsoft/pxt-arcade#6758