Dark Theme Fixes #10416
Dark Theme Fixes #10416
Conversation
… generally up against a slightly faded background, in which case foreground is going to be the most visible. Fixes an issue in the share -> embed toggle.
…dge, is only used for user-provided extension disclaimer.
…e both foreground and background get set anyway (and they're causing the colors to get overriden in dark theme)
| @@ -121,7 +121,7 @@ class AssetGalleryImpl extends React.Component<AssetGalleryProps, AssetGallerySt | |||
| <AssetTopbar /> | |||
| <div className={`asset-editor-card-list ${view !== GalleryView.User ? "hidden" : ""}`}> | |||
| <AssetCardList assets={filterAssets(userAssets, isBlocksProject)}> | |||
| <Button className="create-new inverted" | |||
| <Button className="create-new" | |||
There was a problem hiding this comment.
If I'm understanding your commit comment correctly, this fix is supposed to address microsoft/pxt-arcade#6780. I'm not sure if this fixes the problem in the regular dark theme, but it's still broken in high contrast on the upload target. Sorry if this is unrelated.
There was a problem hiding this comment.
That's a different bug. This is actually compensating for the fix for microsoft/pxt-arcade#6775. That bug required an override in arcade-dark css for inverted buttons (see microsoft/pxt-arcade#6785), but that override was also affecting these buttons, which was undesirable.
Ultimately, the inverted class here is unnecessary because the colors are set directly for them, anyway. So the simplest fix is just to remove the inverted class from these elements altogether.
There was a problem hiding this comment.
Oh, interesting! Thanks for the clarification!
Fixes some of the dark theme issues spotted in testing today. Generally speaking, each commit = 1 issue (though some are split in arcade changes too: microsoft/pxt-arcade#6785).
Fixes microsoft/pxt-arcade#6781
Fixes microsoft/pxt-arcade#6762
Fixes microsoft/pxt-arcade#6763
Fixes microsoft/pxt-arcade#6774
Fixes microsoft/pxt-arcade#6778
Also fixes input fields in report abuse and the dropdown menu for choosing hardware.
Upload Target: https://arcade.makecode.com/app/5711563fab6ebb9e9bae48fac06f5fed01f9053d-867f791e15