A couple of function dialog fixes #10415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srietkerk
reviewed
Mar 7, 2025
| @@ -1,21 +1,18 @@ | |||
| import * as Blockly from "blockly"; | |||
| import { FunctionManager } from "../functionManager"; | |||
| import { ArgumentEditorBlock } from "../blocks/argumentEditorBlocks"; | |||
|
|
|||
| export interface FieldArgumentEditorConfig extends Blockly.FieldTextInputConfig { | |||
There was a problem hiding this comment.
Do we still need this as a separate interface if it no longer adds something to the Blockly.FieldTextInputConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-arcade#6764
fixes microsoft/pxt-arcade#6770
a couple of fixes for the function dialog!
first one is a bug with the initialization of the argument editors for custom non-primitive types. i ran into the same thing when doing #10402; basically initSvg was getting caused out of order which led to weirdness. this change just switches them to be the same as all of the other types rather than using domToBlock
second one was just an oversight when i rewrote the functions implementation during the great blockly swap. i guess i never tested this!