-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several Theme Fixes - New Preference Format, Color Tweaks #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…targets. Also change setColorTheme -> setColorThemeById and make saving the preference optional (was needed for theme builder, thought it was a good change anyway). Lastly, if the configured theme is somehow unrecognized, just use the default theme.
…ks/theme_assorted_fixes
riknoll
approved these changes
Mar 6, 2025
Co-authored-by: Richard Knoll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a few theme fixes.
Changed theme preference storage to be target-based
Fixes microsoft/pxt-arcade#6735
Before, it was a single theme id regardless of target, so if you changed themes in arcade, that would clear your preference for microbit, and so on...
Menu Text Change
Change "Select Theme" to just "Theme" (more consistent with "Language" in the same menu)
A Few Color Fixes
Additional Tweaks
Some additional changes & refactoring based on findings while working on theme builder, including:
setColorThemeById
instead of justsetColorTheme
, leaving the door open for setting by theme object in the futureUpload Target: https://arcade.makecode.com/app/7d7ad2f89b8743f9b1e89290dfb6a8d17e39db85-d113d4beed