Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Theme Fixes - New Preference Format, Color Tweaks #10409

Merged
merged 19 commits into from
Mar 7, 2025

Conversation

thsparks
Copy link
Contributor

@thsparks thsparks commented Mar 6, 2025

This contains a few theme fixes.

Changed theme preference storage to be target-based
Fixes microsoft/pxt-arcade#6735
Before, it was a single theme id regardless of target, so if you changed themes in arcade, that would clear your preference for microbit, and so on...

Menu Text Change
Change "Select Theme" to just "Theme" (more consistent with "Language" in the same menu)

A Few Color Fixes

  1. Fixes "Arcade Dark": The words 'Prepare Your Ship' cannot display. pxt-arcade#6743
  2. Fixes "Arcade Legacy" "Arcade Light": The contents under the simulator can't be visible clearly after switching to JavaScript and Python pxt-arcade#6748
  3. Fixes "Arcade Dark": The text can't be clearly visible in the 'Project Saved!' dialog. pxt-arcade#6739
  4. Fixes "Arcade Dark" "High Contrast": The hint can't be clearly visible in the JavaScript and Python tutorials. pxt-arcade#6745
  5. Fixes Cannot see the category in toolbox when set High Contrast and Green Screen On pxt-arcade#6309
  6. A few others that didn't have bugs filed... (disabled buttons, new/cloud project cards hover, neutral labels, fg/bg mismatch on home page categories)

Additional Tweaks
Some additional changes & refactoring based on findings while working on theme builder, including:

  1. Adding a neutral base color
  2. Specifying setColorThemeById instead of just setColorTheme, leaving the door open for setting by theme object in the future
  3. Making it optional to save the preference when setting the theme
  4. Partial changes toward fixing Need Dark-Theme Versions of Dark Icons pxt-arcade#6751 but also need arcade changes for that.

Upload Target: https://arcade.makecode.com/app/7d7ad2f89b8743f9b1e89290dfb6a8d17e39db85-d113d4beed

@thsparks thsparks requested a review from a team March 6, 2025 02:03
@thsparks thsparks merged commit 43aef17 into master Mar 7, 2025
6 checks passed
@thsparks thsparks deleted the thsparks/theme_assorted_fixes branch March 7, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment