Do not use "in" for checking if a themeId is known

microsoft · Mar 7, 2025 · 801ec14 · 801ec14
1 parent 8e956d9
commit 801ec14
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/react-common/components/theming/themeManager.ts b/react-common/components/theming/themeManager.ts
@@ -31,7 +31,7 @@ export class ThemeManager {
     }
 
     public isKnownTheme(themeId: string): boolean {
-        return pxt.appTarget.colorThemeMap && themeId in pxt.appTarget.colorThemeMap;
+        return !!pxt.appTarget?.colorThemeMap?.[themeId];
     }
 
     public getAllColorThemes(): pxt.ColorThemeInfo[] {