Add Themes for Arcade (and bump pxt-core) #6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thsparks/theme_fixes
srietkerk
approved these changes
Feb 26, 2025
| @@ -7,7 +7,7 @@ | |||
| div.blocklyTreeRow { | |||
| margin-bottom: 0px !important; | |||
| transition-property: background-color; | |||
| transition-duration: 1s; | |||
| transition-duration: 0.2s; | |||
There was a problem hiding this comment.
Is there a reason this was reduced?
There was a problem hiding this comment.
@riknoll Mentioned during testing that the on-hover's color transition seemed too long, and ever since he pointed it out, I can't unsee it. It feels really long at 1 second. So I just shortened it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds light, legacy, and dark themes for arcade, based on changes in microsoft/pxt#10391
It also bumps pxt-core to get those changes.
Upload target: https://arcade.makecode.com/app/bd228f8101401d913f282b0c3585b210d67a903b-d766c6703c