Add check for audio sampling rate other than 8k or 16k Hz #898
Conversation
sayanshaw24
changed the title
shared/api/speech_features.hpp
Outdated
|
|
||
| // Currently we only support 8k and 16k Hz sampling rate. | ||
| if (sr_val != 8000 && sr_val != 16000){ | ||
| ORTX_CXX_API_THROW("ort-extensions internal error: currently only 8k and 16k Hz sampling rate is supported. Please resample your audio file to either 8k or 16k.", ORT_RUNTIME_EXCEPTION); |
There was a problem hiding this comment.
to be more Ort-Mobile friendly and be consistent, please try to return the error status, instead of throwing an exception.
There was a problem hiding this comment.
Also, could we avoid adding library's name in the error message reported? To the end user, it may be confusing to see ort-extensions error if there are multiple libraries involved: win-ai-gallery -> aitk -> ort-genai -> ort-extensions ...
There was a problem hiding this comment.
Also, could we avoid adding library's name in the error message reported? To the end user, it may be confusing to see ort-extensions error if there are multiple libraries involved: win-ai-gallery -> aitk -> ort-genai -> ort-extensions ...
on calling ort-extensions from ort-genai, only error code and error message are expected. so, ort-genai can add whatever prefix for the error message from ort-extensions or filtering error message, but it will be lack of information if we got some error report from the user
it would be nice if there is an error report which can be posted into ort-extensions issue to fully understanding the issue. Typically, the audio format should be handled audio-decoder. |
Fixes issue where user was getting vague error when using audio file with 48k Hz sampling rate:
onnxruntime-extensions/include/ort_c_to_cpp.h
Line 109 in 0d5aefa