Add a new output for num audio frames #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanshaw24
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Thanks so much for adding this!
Looks mostly good, just in https://github.com/microsoft/onnxruntime-extensions/blob/main/test/pp_api_test/test_feature_extraction.cc, lines 68 and 103 need to be changed from ASSERT_EQ(num_dims, 1); to ASSERT_EQ(num_dims, 2); to reflect the added output and fix the C++ unit test failures I believe.
kunal-vaishnavi
previously approved these changes
Feb 26, 2025
baijumeswani
force-pushed
the
baijumeswani/num-audio-frames
branch
from
8c5f2fb to
6a50f05
Compare
sayanshaw24
approved these changes
Feb 26, 2025
kunal-vaishnavi
approved these changes
Feb 26, 2025
|
Thanks for the review. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.