Update CMakeLists.txt: change "re2" to re2::re2 #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbingl
reviewed
Mar 1, 2025
| @@ -331,7 +331,7 @@ if(OCOS_ENABLE_RE2_REGEX) | |||
| endif() | |||
|
|
|||
| if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten") | |||
| set_property(TARGET re2 PROPERTY COMPILE_OPTIONS) | |||
| set_property(TARGET re2::re2 PROPERTY COMPILE_OPTIONS) | |||
There was a problem hiding this comment.
The error message is following, did you get it work for any lib in onnxruntime project?
CMake Error at CMakeLists.txt:334 (set_property):
set_property can not be used on an ALIAS target.
There was a problem hiding this comment.
Yeah, it works there. This is strange.
|
Will work on it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is similar to #872 . Somehow last time I missed it.