Add C++ regex support for Llama3, Standard Library, and Custom Cases #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanshaw24
changed the title
added 3 commits
September 9, 2024 16:50
sayanshaw24
changed the title
sayanshaw24
commented
Sep 10, 2024
wenbingl
reviewed
Sep 10, 2024
| @@ -133,7 +133,7 @@ TEST(OrtxTokenizerTest, Phi3_S_Tokenizer) { | |||
| EXPECT_NE(tokenizer, nullptr); | |||
|
|
|||
| std::vector<extTokenId_t> EXPECTED_IDS_0 = {2028, 374, 264, 1296, 13}; | |||
| std::vector<std::string_view> input = {"This is a test.", "the second one", | |||
| std::vector<std::string_view> input = {"This is a test.", "Ich liebe München", | |||
There was a problem hiding this comment.
I don't think the problem is related to this regular expression. Is it just an enhancement of unit test?
wenbingl
reviewed
Sep 10, 2024
wenbingl
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our regular expression pattern matching for BPE tokenization only supports the GPT2 regex.
This PR adds the following functionality: