Remove OpenCV dependency from C_API mode #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbingl
changed the title
sayanshaw24
reviewed
Sep 4, 2024
| endif() | ||
|
|
||
| set(lib_srcs | ||
| ${libPNG_SOURCE_DIR}/arm/arm_init.c |
There was a problem hiding this comment.
is there a reason we include all these files individually rather than put them in folders and include the folders instead for efficiency? (same for libjpeg)
There was a problem hiding this comment.
Yes, there are some unnecessary source files in the folder, and cannot be compiled easily. e.g. a lot of build configuraiton and tunning.
sayanshaw24
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some unit tests.