Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UefiHidDxeV2: Fix Keyboard LED Sync Issue #641

Merged

Conversation

wenbhou
Copy link
Contributor

@wenbhou wenbhou commented Mar 5, 2025

Description

Fixes #642

Current UefiHidDxeV2 is unable to sync the keyboard LED state from the integrated keyboard to external USB keyboards connected to a laptop, resulting in a poor user experience.
This change aims to fix this issue to ensure the keyboard LED state can sync between the integrated keyboard and external USB keyboards.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on the Laptop, the keyboard LED state can sync between the integrated keyboard and external USB keyboards.

Integration Instructions

N/A

@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Mar 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.59%. Comparing base (1f14573) to head (546b022).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #641   +/-   ##
===========================================
  Coverage       11.59%   11.59%           
===========================================
  Files             132      132           
  Lines           21558    21558           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19025    19025           
  Partials           34       34           
Flag Coverage Δ
HidPkg 2.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki added the type:bug Something isn't working label Mar 5, 2025
@makubacki makubacki requested a review from Javagedes March 5, 2025 01:03
@apop5 apop5 merged commit 46324dd into microsoft:dev/202405 Mar 5, 2025
38 checks passed
@wenbhou wenbhou deleted the personal/wenbhou/fix_rust_kb_led branch March 5, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:backport Backport changes in a dev branch PR to its release branch. type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Caps Lock state cannot sync between internal keyboard and external USB keyboards
5 participants