Fix infinite loop issue in UsbGetFullHidDescriptor #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
NishanthSanjeevi
force-pushed
the
personal/nishanth/fix_infinite_loop
branch
from
0b74fb4 to
4811932
Compare
github-actions
bot
added
the
type:backport
makubacki
reviewed
Mar 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #640 +/- ##
==============================================
- Coverage 11.59% 11.59% -0.01%
==============================================
Files 132 132
Lines 21555 21558 +3
Branches 2546 2546
==============================================
Hits 2499 2499
- Misses 19022 19025 +3
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
approved these changes
Mar 4, 2025
joschock
approved these changes
Mar 4, 2025
github-actions
bot
added
the
impact:non-functional
I agree. Programmatically this case should be handled. |
apop5
approved these changes
Mar 4, 2025
kuqin12
approved these changes
Mar 4, 2025
ProjectMuBot
pushed a commit
that referenced
this pull request
Mar 4, 2025
## Description UsbGetFullHidDescriptor does not check the Descriptor header length and this might result in an infinite loop if a bad descriptor is passed. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested Tested on Surface devices ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UsbGetFullHidDescriptor does not check the Descriptor header length and this might result in an infinite loop if a bad descriptor is passed.
How This Was Tested
Tested on Surface devices
Integration Instructions
N/A