[CHERRY-PICK] [202311] Reset the keyboard to default state during initialization #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#633 Reset the keyboard to default state during initialization in order to make sure the LED status on keyboard is determined. - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? Tested on Surface Laptop and Surface Pro, all keyboard LEDs are turned off when booting to the UEFI front page. No regressions observed. N/A (cherry picked from commit f55d046)
makubacki
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #635 +/- ##
===============================================
Coverage 11.02% 11.02%
===============================================
Files 144 144
Lines 22065 22065
Branches 2356 2356
===============================================
Hits 2432 2432
Misses 19601 19601
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kenlautner
approved these changes
Feb 18, 2025
Javagedes
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #633
Reset the keyboard to default state during initialization in order to make sure the LED status on keyboard is determined.
(cherry picked from commit f55d046)
How This Was Tested
Tested on Surface Laptop and Surface Pro, all keyboard LEDs are turned off when booting to the UEFI front page.
No regressions observed.
Integration Instructions
N/A