AdvLoggerPkg: Fix message handling and LineParserTestApp #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:breaking-change
kuqin12
approved these changes
Feb 18, 2025
makubacki
force-pushed
the
fix_advlogger_phase_dbglevel_handling
branch
from
18b8607 to
ad41c4c
Compare
A case existed where the target buffer was not correct whenever the same line buffer was extended (previous message overwritten). Debug level strings could overwrite characters if a new debug level was changed when residual characters were added to the same line buffer. To simplify handling of strings, this change makes the phases and debug message levels a fixed size. This is a breaking change but less error prone. The LineParserTestApp needed to be updated for debug level strings, so that is done. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
fix_advlogger_phase_dbglevel_handling
branch
from
ad41c4c to
76147d2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #634 +/- ##
===========================================
Coverage 11.59% 11.59%
===========================================
Files 132 132
Lines 21561 21555 -6
Branches 2546 2546
===========================================
Hits 2499 2499
+ Misses 19028 19022 -6
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Feb 19, 2025
cfernald
approved these changes
Feb 19, 2025
ProjectMuBot
pushed a commit
that referenced
this pull request
Feb 25, 2025
## Description Fixes #629 A case existed where the target buffer was not correct whenever the same line buffer was extended (previous message overwritten). Debug level strings could overwrite characters if a new debug level was changed when residual characters were added to the same line buffer. To simplify handling of strings, this change makes the phases and debug message levels a fixed size. This is a breaking change but less error prone. The LineParserTestApp needed to be updated for debug level strings, so that is done. - [x] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [x] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested - LineParserTestApp - Step through parsing with debugger and check variable values - Log output ## Integration Instructions - If any tools or code depend on exact string matches, note the change in the debug message level and phase strings. Signed-off-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #629
A case existed where the target buffer was not correct whenever the same line buffer was extended (previous message overwritten).
Debug level strings could overwrite characters if a new debug level was changed when residual characters were added to the same line buffer. To simplify handling of strings, this change makes the phases and debug message levels a fixed size. This is a breaking change but less error prone.
The LineParserTestApp needed to be updated for debug level strings, so that is done.
How This Was Tested
Integration Instructions